IGNITE-27626 Use MessageSerializer for custom messages #12651
Conversation
shishkovilja
force-pushed
the
ignite-27626
branch
2 times, most recently
from
f529d25 to
6ee242b
Compare
shishkovilja
changed the title
shishkovilja
force-pushed
the
ignite-27626
branch
6 times, most recently
from
4e7c1db to
bae6713
Compare
shishkovilja
force-pushed
the
ignite-27626
branch
from
50cdcd5 to
f87dbb3
Compare
|
| * @param caches Collection of cache names. | ||
| */ | ||
| public CacheStatisticsModeChangeMessage(UUID reqId, Collection<String> caches, boolean enabled) { | ||
| public CacheStatisticsModeChangeMessage(IgniteUuid id, UUID reqId, Collection<String> caches, boolean enabled) { |
There was a problem hiding this comment.
We always pass IgniteUuid.randomUuid() for the id argument in the constructor.
Maybe we should remove id from the constructor arguments and just initialize it inside the constructor?
This also applies to the private constructor.
By the way, we could also remove the UUID reqId argument and initialize it as UUID.randomUUID() instead.
There was a problem hiding this comment.
Sounds reasonable.
| serMsg = (Message)msg; | ||
| else { | ||
| assert msgBytes == null || msg.isMutable() : "Message bytes are not null for immutable message: bytes=" + | ||
| Arrays.toString(msgBytes) + "]"; |
| msg = (DiscoveryCustomMessage)serMsg; | ||
| else { | ||
| try { | ||
| msg = U.unmarshal(marsh, msgBytes, ldr); |
There was a problem hiding this comment.
Should we add a check that msgBytes != null?
There was a problem hiding this comment.
In fact, if msgBytes == null, it is an incorrect state of message. Unmarshal will fail with an asserion error.
2 participants
No description provided.